Add support for Scala 2.13 #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an ignored test for Scala 2.13 added in eyalroth@69bb994. You could re-enable it and test your fix with it :) Also, IIRC, there was a problem with selecting source encoding in the scalac plugin itself. See #68 (comment) |
|
You can see in "Files changed" that I had already removed the I did come across that issue and #70, but I didn't find yet a test that would break if the source encoding part is removed. I didn't try too hard though. As is, at the moment, if I don't set the |
helfper
force-pushed
the
scala213-support
branch
from
7e87fef to
812055a
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix may look a bit "hacky" because it uses reflection to be able to set the correct
sourceEncoding(BTW it seems there's no test covering that), but it may be worth it in the short-term until we see some movement in scalac-scoverage-plugin, as it has been almost one year without any releases there, and Scala 2.13 came out well over a year now.This is the only solution I think of that can work with the current scalac-scoverage-plugin without requiring cross-building on gradle-scoverage side. The other constructors in ScoverageHtmlWriter use scala.Seq which is effectively a different type in Scala 2.12 and 2.13, so only cross-building could get over it.
Fixes #106